netdev - Re: [PATCH net-next] mac80211: silent build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54AE7F3F.3070802@cogentembedded.com>
Date:	Thu, 08 Jan 2015 15:59:43 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ying Xue <ying.xue@...driver.com>, johannes@...solutions.net
CC:	netdev@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next] mac80211: silent build warnings

Hello.

On 1/8/2015 10:04 AM, Ying Xue wrote:

> Silent the following build warnings:

> net/mac80211/mlme.c: In function ‘ieee80211_rx_mgmt_beacon’:
> net/mac80211/mlme.c:1348:3: warning: ‘pwr_level_cisco’ may be used uninitialized in this function [-Wuninitialized]
> net/mac80211/mlme.c:1315:6: note: ‘pwr_level_cisco’ was declared here

> Signed-off-by: Ying Xue <ying.xue@...driver.com>
> ---
>   net/mac80211/mlme.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 2c36c47..13b5506 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -1312,7 +1312,7 @@ static u32 ieee80211_handle_pwr_constr(struct ieee80211_sub_if_data *sdata,
>   {
>   	bool has_80211h_pwr = false, has_cisco_pwr = false;
>   	int chan_pwr = 0, pwr_reduction_80211h = 0;
> -	int pwr_level_cisco, pwr_level_80211h;
> +	int pwr_level_cisco = 0, pwr_level_80211h = 0;

    OK, but why are you also initializing the second variable?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html