[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150108.200541.293054368842403637.davem@davemloft.net>
Date: Thu, 08 Jan 2015 20:05:41 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: festevam@...il.com
Cc: shawn.guo@...aro.org, fugang.duan@...escale.com,
netdev@...r.kernel.org, fabio.estevam@...escale.com
Subject: Re: [PATCH net-next 1/2] Revert "ARM: imx: add FEC sleep mode
callback function"
From: Fabio Estevam <festevam@...il.com>
Date: Wed, 7 Jan 2015 10:39:52 -0200
> From: Fabio Estevam <fabio.estevam@...escale.com>
>
> i.MX platform maintainer Shawn Guo is not happy with the such commit as
> explained below [1]:
>
> "The GPR difference between SoCs can be encoded in device tree as well.
> It's pointless to repeat the same code pattern for every single
> platform, that need to set up GPR bits for enabling magic packet wake
> up, while the only difference is the register and bit offset.
>
> The platform code will become quite messy and unmaintainable if every
> device driver dump their GPR register setup code into platform.
>
> Sorry, but it's NACK from me."
>
> This reverts commit 456062b3ec6f5b9 ("ARM: imx: add FEC sleep mode callback
> function").
>
> [1] http://www.spinics.net/lists/netdev/msg310922.html
>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists