netdev - Re: [PATCH net-next 07/11] r8169:update rtl8168f pcie ephy parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150108.200858.548066819871890131.davem@davemloft.net>
Date:	Thu, 08 Jan 2015 20:08:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	David.Laight@...LAB.COM
Cc:	hau@...ltek.com, netdev@...r.kernel.org, nic_swsd@...ltek.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 07/11] r8169:update rtl8168f pcie ephy
 parameter

From: David Laight <David.Laight@...LAB.COM>
Date: Wed, 7 Jan 2015 16:45:58 +0000

> From: Chunhao Lin
>> @@ -5852,7 +5852,9 @@ static void rtl_hw_start_8168f_1(struct rtl8169_private *tp)
>>  		{ 0x06, 0x00c0,	0x0020 },
>>  		{ 0x08, 0x0001,	0x0002 },
>>  		{ 0x09, 0x0000,	0x0080 },
>> -		{ 0x19, 0x0000,	0x0224 }
>> +		{ 0x19, 0x0000,	0x0224 },
>> +		{ 0x00, 0x0000,	0x0008 },
>> +		{ 0x0c, 0x3df0,	0x0200 }
> 
> I can't help feeling these lines all require short comments.

Agreed.

And this goes for some of the other patches that look like this too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html