netdev - Re: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54B2E4DD.90200@nod.at>
Date:	Sun, 11 Jan 2015 22:02:21 +0100
From:	Richard Weinberger <richard@....at>
To:	Joe Perches <joe@...ches.com>
CC:	davem@...emloft.net, coreteam@...filter.org,
	netfilter-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, bhutchings@...arflare.com,
	john.fastabend@...il.com, herbert@...dor.apana.org.au,
	vyasevic@...hat.com, jiri@...nulli.us, vfalico@...il.com,
	therbert@...gle.com, edumazet@...gle.com, yoshfuji@...ux-ipv6.org,
	jmorris@...ei.org, kuznet@....inr.ac.ru, kadlec@...ckhole.kfki.hu,
	kaber@...sh.net, pablo@...filter.org, kay@...y.org,
	stephen@...workplumber.org
Subject: Re: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname_compare()

Am 11.01.2015 um 21:59 schrieb Joe Perches:
> On Sun, 2015-01-11 at 21:52 +0100, Richard Weinberger wrote:
>> arp_tables.c has a 16bit aligment ifname_compare(), factor
>> it out to use it for all tables.
> []
>> diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h
> []
>> @@ -331,14 +331,15 @@ static inline void xt_write_recseq_end(unsigned int addend)
>>  /*
>>   * This helper is performance critical and must be inlined
>>   */
>> -static inline unsigned long ifname_compare_aligned(const char *_a,
>> -						   const char *_b,
>> -						   const char *_mask)
>> +static inline unsigned long ifname_compare(const char *_a,
>> +					   const char *_b,
>> +					   const char *_mask)
> 
> Perhaps this would be better as bool ifname_compare

Let's discuss the whole concept first, then we can go to bikeshedding mode.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html