netdev - Re: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1421012376.9233.9.camel@perches.com>
Date:	Sun, 11 Jan 2015 13:39:36 -0800
From:	Joe Perches <joe@...ches.com>
To:	Richard Weinberger <richard@....at>
Cc:	davem@...emloft.net, coreteam@...filter.org,
	netfilter-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, bhutchings@...arflare.com,
	john.fastabend@...il.com, herbert@...dor.apana.org.au,
	vyasevic@...hat.com, jiri@...nulli.us, vfalico@...il.com,
	therbert@...gle.com, edumazet@...gle.com, yoshfuji@...ux-ipv6.org,
	jmorris@...ei.org, kuznet@....inr.ac.ru, kadlec@...ckhole.kfki.hu,
	kaber@...sh.net, pablo@...filter.org, kay@...y.org,
	stephen@...workplumber.org
Subject: Re: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname_compare()

On Sun, 2015-01-11 at 22:30 +0100, Richard Weinberger wrote:
> Am 11.01.2015 um 22:14 schrieb Joe Perches:
> > On Sun, 2015-01-11 at 22:02 +0100, Richard Weinberger wrote:
> >> Am 11.01.2015 um 21:59 schrieb Joe Perches:
> >>> On Sun, 2015-01-11 at 21:52 +0100, Richard Weinberger wrote:
> >>>> arp_tables.c has a 16bit aligment ifname_compare(), factor
> >>>> it out to use it for all tables.
> > []
> >>> Perhaps this would be better as bool ifname_compare
> >> Let's discuss the whole concept first
> > 
> > The concept seems obvious enough
> 
> Anyway, I agree with Linus wrt. bool.
> https://lkml.org/lkml/2013/8/31/138

I don't.  He was right when he wrote:

https://lkml.org/lkml/2014/3/10/760

Linus Torvalds <>
I guess I haven't gotten over my hatred of people playing games with
them because support wasn't universal enough. But maybe it's
approaching being irrational these days.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html