netdev - Re: [PATCH net-next 2/3] netlink: eliminate nl_sk_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150112.162703.804704527828090208.davem@davemloft.net>
Date:	Mon, 12 Jan 2015 16:27:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	ying.xue@...driver.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] netlink: eliminate nl_sk_hash_lock

From: Thomas Graf <tgraf@...g.ch>
Date: Fri, 9 Jan 2015 10:55:16 +0000

> Since this code can now run in parallel, there is a race between
> checking portid and then setting it. CPU#1 could overwrite portid after
> CPU#0 has already checked portid, this would then insert the socket on
> CPU#0 with the portid created on CPU#1. So this would need some kind
> of atomic operation.

Thomas, please review Ying's new version of this patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html