netdev - Re: [PATCH net] alx: fix alx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150111.214636.57922661070968241.davem@davemloft.net>
Date:	Sun, 11 Jan 2015 21:46:36 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	oded.gabbay@....com, johannes.berg@...el.com, edumazet@...gle.com,
	netdev@...r.kernel.org, willemb@...gle.com, John.Bridgman@....com,
	Dana.Elifaz@....com
Subject: Re: [PATCH net] alx: fix alx_poll()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 11 Jan 2015 10:32:18 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Commit d75b1ade567f ("net: less interrupt masking in NAPI") uncovered
> wrong alx_poll() behavior.
> 
> A NAPI poll() handler is supposed to return exactly the budget when/if
> napi_complete() has not been called.
> 
> It is also supposed to return number of frames that were received, so
> that netdev_budget can have a meaning.
> 
> Also, in case of TX pressure, we still have to dequeue received
> packets : alx_clean_rx_irq() has to be called even if
> alx_clean_tx_irq(alx) returns false, otherwise device is half duplex.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Fixes: d75b1ade567f ("net: less interrupt masking in NAPI")
> Reported-by: Oded Gabbay <oded.gabbay@....com>
> Bisected-by: Oded Gabbay <oded.gabbay@....com>
> Tested-by: Oded Gabbay <oded.gabbay@....com>

Applied and queued up for -stable, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html