netdev - Re: [PATCH v3] ath10k: fixup wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Jan 2015 14:39:22 +0200
From:	Kalle Valo <kvalo@....qualcomm.com>
To:	Nicholas Mc Guire <der.herr@...r.at>
Cc:	Chun-Yeow Yeoh <yeohchunyeow@...il.com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	<netdev@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <ath10k@...ts.infradead.org>,
	Michal Kazior <michal.kazior@...to.com>,
	Yanbo Li <yanbol@....qualcomm.com>,
	Ben Greear <greearb@...delatech.com>
Subject: Re: [PATCH v3] ath10k: fixup wait_for_completion_timeout return handling

Nicholas Mc Guire <der.herr@...r.at> writes:

> wait_for_completion_timeout does not return negative values so the tests
> for <= 0 are not needed and the case differentiation in the error handling
> path unnecessary.
>
> v2: all wait_for_completion_timeout changes in a single patch
> v3: patch formatting cleanups - no change of actual patch
>
> Signed-off-by: Nicholas Mc Guire <der.herr@...r.at>
> ---
> patch was only compile tested x86_64_defconfig + CONFIG_ATH_CARDS=m
> CONFIG_ATH10K=m
>
> patch is against linux-next 3.19.0-rc1 -next-20141226
>
> None of the proposed cleanups are critical.
> All changes should only be removing unreachable cases.

Sorry, I wasn't clear enough in my last email but everything related to
v2, v3 etc should be after "---" line. I fixed this in ath-next-test
branch and will apply your patch once kbuild has run it's tests.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html