netdev - Re: [PATCH net-next v2 0/3] remove nl_sk_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150113.140123.1462176338597652543.davem@davemloft.net>
Date:	Tue, 13 Jan 2015 14:01:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ying.xue@...driver.com
Cc:	tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/3] remove nl_sk_hash_lock from netlink
 socket

From: Ying Xue <ying.xue@...driver.com>
Date: Mon, 12 Jan 2015 14:52:21 +0800

> After tipc socket successfully avoids the involvement of an extra lock
> with rhashtable_lookup_insert(), it's possible for netlink socket to
> remove its hash socket lock now. But as netlink socket needs a compare
> function to look for an object, we first introduce a new function
> called rhashtable_lookup_compare_insert() in commit #1 which is
> implemented based on original rhashtable_lookup_insert(). We
> subsequently remove nl_sk_hash_lock from netlink socket with the new
> introduced function in commit #2. Lastly, as Thomas requested, we add
> commit #3 to indicate the implementation of what the grow and shrink
> decision function must enforce min/max shift.
> 
> v2:
>  As Thomas pointed out, there was a race between checking portid and
>  then setting it in commit #2. Now use socket lock to make the process
>  of both checking and setting portid atomic, and then eliminate the
>  race.

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html