netdev - Re: [PATCH] i40e: avoid use of uninitialized v_budget in i40e_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1421175793.2528.7.camel@jtkirshe-mobl>
Date:	Tue, 13 Jan 2015 11:03:13 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	netdev@...r.kernel.org, Linux NICS <linux.nics@...el.com>
Subject: Re: [PATCH] i40e: avoid use of uninitialized v_budget in
 i40e_init_msix

On Tue, 2015-01-13 at 13:48 -0500, John W. Linville wrote:
> This I40E_FCOE block increments v_budget before it has been
> initialized,
> then v_budget gets overwritten a few lines later.  This patch just
> reorders the code hunks in what I believe was the intended sequence.
> 
> Coverity: CID 1260099
> 
> Signed-off-by: John W. Linville <linville@...driver.com>
> ---
> Compile tested only...
> 
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Thanks John, I will add your patch to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)