netdev - Re: [PATCH 3/6] net: davinci_emac: Free clock after checking the frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2015 16:05:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tony@...mide.com
Cc:	thomas.lendacky@....com, netdev@...r.kernel.org,
	linux-omap@...r.kernel.org, b.hutchman@...il.com, balbi@...com
Subject: Re: [PATCH 3/6] net: davinci_emac: Free clock after checking the
 frequency

From: Tony Lindgren <tony@...mide.com>
Date: Tue, 13 Jan 2015 11:54:16 -0800

> * Tom Lendacky <thomas.lendacky@....com> [150113 11:51]:
>> On 01/13/2015 01:29 PM, Tony Lindgren wrote:
>> >We only use clk_get() to get the frequency, the rest is done by
>> >the runtime PM calls. Let's free the clock too.
>> >
>> >Cc: Brian Hutchinson <b.hutchman@...il.com>
>> >Cc: Felipe Balbi <balbi@...com>
>> >Signed-off-by: Tony Lindgren <tony@...mide.com>
>> >---
>> >  drivers/net/ethernet/ti/davinci_emac.c | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> >diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
>> >index deb43b3..e9efc74 100644
>> >--- a/drivers/net/ethernet/ti/davinci_emac.c
>> >+++ b/drivers/net/ethernet/ti/davinci_emac.c
>> >@@ -1881,6 +1881,7 @@ static int davinci_emac_probe(struct platform_device *pdev)
>> >  		return -EBUSY;
>> >  	}
>> >  	emac_bus_frequency = clk_get_rate(emac_clk);
>> >+	clk_put(emac_clk);
>> 
>> The devm_clk_get call is used to get the clock so either a devm_clk_put
>> needs to be used here or just let the devm_ call do its thing and
>> automatically do the put when the module is unloaded.
> 
> Thanks good catch, updated patch below.

Please, once all the feedback has been addressed, repost the entire
series.

THanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html