netdev - Re: [PATCH 8/8] ath10k: fix error return code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ppai6a0n.fsf@kamboji.qca.qualcomm.com>
Date:	Tue, 13 Jan 2015 16:16:40 +0200
From:	Kalle Valo <kvalo@....qualcomm.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
CC:	<linux-wireless@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<ath10k@...ts.infradead.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 8/8] ath10k: fix error return code

Julia Lawall <Julia.Lawall@...6.fr> writes:

> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Thanks, applied to ath.git.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html