netdev - Re: [PATCH net 0/3]tg3: synchronize_irq() should be called without taking locks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1421262262.16485.17.camel@prashant>
Date:	Wed, 14 Jan 2015 11:04:22 -0800
From:	Prashant Sreedharan <prashant@...adcom.com>
To:	Peter Hurley <peter@...leysoftware.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<mchan@...adcom.com>
Subject: Re: [PATCH net 0/3]tg3: synchronize_irq() should be called without
 taking locks

On Wed, 2015-01-14 at 10:57 -0500, Peter Hurley wrote:
> On 01/14/2015 01:30 AM, Prashant Sreedharan wrote:
> > Prashant Sreedharan (3):
> >   tg3_timer() should grab tp->lock before checking for tp->irq_sync
> >   tg3_reset_task() needs to use rtnl_lock to synchronize
> >   Release tp->lock before invoking synchronize_irq()
> 
> Thanks!
> 
> For series:
> 
> Reported-by: Peter Hurley <peter@...leysoftware.com>
> Tested-by: Peter Hurley <peter@...leysoftware.com>
> 
> But maybe one of these patches should reference that this fixes
> BUG: sleeping function... so that others can quickly find this
> fix (if they're bisecting or whatever). 

Sure will add

> For the same reason, it
> might be useful for this series to be just one patch.

These are logical different sections of code, I prefer them to be small
patches.

> 
> Regards,
> Peter Hurley
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html