netdev - Re: [PATCH net] openvswitch: packet messages need their own probe attribtue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEP_g=_Z_OUyNU=_ctFDAgLR=yDjsO_L4tNLSzGS=7oir39uVw@mail.gmail.com>
Date:	Wed, 14 Jan 2015 12:40:44 -0800
From:	Jesse Gross <jesse@...ira.com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	Florian Westphal <fw@...len.de>,
	David Miller <davem@...emloft.net>,
	Sander Eikelenboom <linux@...elenboom.it>,
	Pravin B Shelar <pshelar@...ira.com>,
	netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>,
	Jarno Rajahalme <jrajahalme@...ira.com>
Subject: Re: [PATCH net] openvswitch: packet messages need their own probe attribtue

On Wed, Jan 14, 2015 at 5:56 AM, Thomas Graf <tgraf@...g.ch> wrote:
> User space is currently sending a OVS_FLOW_ATTR_PROBE for both flow
> and packet messages. This leads to an out-of-bounds access in
> ovs_packet_cmd_execute() because OVS_FLOW_ATTR_PROBE >
> OVS_PACKET_ATTR_MAX.
>
> Introduce a new OVS_PACKET_ATTR_PROBE with the same numeric value
> as OVS_FLOW_ATTR_PROBE to grow the range of accepted packet attributes
> while maintaining to be binary compatible with existing OVS binaries.
>
> Fixes: 05da589 ("openvswitch: Add support for OVS_FLOW_ATTR_PROBE.")
> Reported-by: Sander Eikelenboom <linux@...elenboom.it>
> Tracked-down-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Thomas Graf <tgraf@...g.ch>

This is kind of a nasty bug, thanks for fixing it.

Reviewed-by: Jesse Gross <jesse@...ira.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html