netdev - Re: [net-next 16/17] i40e: Support for NPAR iSCSI partition with DCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMhXpwBS1PJhrFkojE4OmrcwT1Luuun3pREn+pGb5r60bw@mail.gmail.com>
Date:	Thu, 15 Jan 2015 19:11:05 +0200
From:	Or Gerlitz <gerlitz.or@...il.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	David Miller <davem@...emloft.net>,
	Neerav Parikh <neerav.parikh@...el.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next 16/17] i40e: Support for NPAR iSCSI partition with DCB

On Thu, Jan 15, 2015 at 2:19 PM, Jeff Kirsher
<jeffrey.t.kirsher@...el.com> wrote:

> --- a/drivers/net/ethernet/intel/i40e/i40e_type.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
> @@ -211,6 +211,7 @@ struct i40e_hw_capabilities {
>         bool evb_802_1_qbh; /* Bridge Port Extension */
>         bool dcb;
>         bool fcoe;
> +       bool iscsi; /* Indicates iSCSI enabled */
>         bool mfp_mode_1;
>         bool mgmt_cem;
>         bool ieee_1588;


Hey Jeff, just a 0.02$ small tip... you can easily save the annoying
addition of bool X_is_supported/enabled cap variable for every new cap
with having a 64 bit flags field with a bit per feature... it also
makes the code much more readable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html