netdev - Re: [linux-nics] [PATCHv4 net] i40e: Implement ndo_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEP_g=8iRKx9HPf0KRt6m=6pqAuMeT8_9GM8L+uFe+bMoxk33Q@mail.gmail.com>
Date:	Wed, 14 Jan 2015 18:24:34 -0800
From:	Jesse Gross <jesse@...ira.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	Joe Stringer <joestringer@...ira.com>,
	netdev <netdev@...r.kernel.org>,
	"linux.nics" <linux.nics@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [linux-nics] [PATCHv4 net] i40e: Implement ndo_gso_check()

On Fri, Dec 26, 2014 at 3:58 PM, Jesse Gross <jesse@...ira.com> wrote:
> On Fri, Dec 5, 2014 at 2:12 PM, Jeff Kirsher
> <jeffrey.t.kirsher@...el.com> wrote:
>> On Fri, 2014-12-05 at 10:41 -0800, Joe Stringer wrote:
>>> ndo_gso_check() was recently introduced to allow NICs to report the
>>> offloading support that they have on a per-skb basis. Add an
>>> implementation for this driver which checks for IPIP, GRE, UDP
>>> tunnels.
>>>
>>> Signed-off-by: Joe Stringer <joestringer@...ira.com>
>>> ---
>>> v4: Simplify the check to just do tunnel header length.
>>>     Fix #define style issue.
>>> v3: Drop IPIP and GRE (no driver support even though hw supports it).
>>>     Check for UDP outer protocol for UDP tunnels.
>>> v2: Expand to include IP in IP and IPv4/IPv6 inside GRE/UDP tunnels.
>>>     Add MAX_INNER_LENGTH (as 80).
>>> ---
>>>  drivers/net/ethernet/intel/i40e/i40e_main.c |   12 ++++++++++++
>>>  1 file changed, 12 insertions(+)
>>
>> Thanks Joe, I will update the patch in my queue with your latest
>> version.
>
> Jeff, as a heads-up, this patch and the corresponding one for fm10k
> will no longer apply now that the ndo has changed. This was changed by
> 5f35227e ("net: Generalize ndo_gso_check to ndo_features_check"). The
> update needed is trivial and is just due to the change in the function
> signature but I'm not sure where you are in the testing process with
> this.

Jeff - just wanted to check if you had seen this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html