netdev - Re: [PATCH v4 20/20] kbuild: add a new kselftest_install make target to install selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1421362698.23332.6.camel@ellerman.id.au>
Date:	Fri, 16 Jan 2015 09:58:18 +1100
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Shuah Khan <shuahkh@....samsung.com>
Cc:	mmarek@...e.cz, masami.hiramatsu.pt@...achi.com,
	gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
	rostedt@...dmis.org, mingo@...hat.com, davem@...emloft.net,
	keescook@...omium.org, tranmanphong@...il.com, cov@...eaurora.org,
	dh.herrmann@...il.com, hughd@...gle.com, bobby.prani@...il.com,
	serge.hallyn@...ntu.com, ebiederm@...ssion.com,
	tim.bird@...ymobile.com, josh@...htriplett.org, koct9i@...il.com,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-api@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v4 20/20] kbuild: add a new kselftest_install make
 target to install selftests

On Wed, 2015-01-14 at 09:32 -0700, Shuah Khan wrote:
> On 01/06/2015 12:43 PM, Shuah Khan wrote:
> > Add a new make target to install to install kernel selftests.
> > This new target will build and install selftests. kselftest
> > target now depends on kselftest_install and runs the generated
> > kselftest script to reduce duplicate work and for common look
> > and feel when running tests.
> > 
> > make kselftest_target:
> > -- exports kselftest INSTALL_KSFT_PATH
> >    default $(INSTALL_MOD_PATH)/lib/kselftest/$(KERNELRELEASE)
> > -- exports INSTALL_KSFT_PATH
> > -- runs selftests make install target
> > 
> > Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> 
> Hi Marek,
> 
> Could you please Ack this patch, if this version looks good,
> so I can take this through ksefltest tree.

Hi Shuah,

I posted what I think is a better approach last week. It's less code and less
repetition, and installs the majority of tests this series missed - ie. the
powerpc ones.

Please at least respond to it before you put this series into next.

https://lkml.org/lkml/2015/1/9/45

cheers


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html