netdev - Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests IRQs we don't use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Jan 2015 18:16:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	balbi@...com
Cc:	mugunthanvnm@...com, tony@...mide.com, linux-omap@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [patch-net-next v2 3/3] net: ethernet: cpsw: don't requests
 IRQs we don't use

From: Felipe Balbi <balbi@...com>
Date: Thu, 15 Jan 2015 09:20:53 -0600

> On Thu, Jan 15, 2015 at 01:19:16PM +0530, Mugunthan V N wrote:
>> On Wednesday 14 January 2015 10:28 PM, Felipe Balbi wrote:
>> > CPSW never uses RX_THRESHOLD or MISC interrupts. In
>> > fact, they are always kept masked in their appropriate
>> > IRQ Enable register.
>> > 
>> > Instead of allocating an IRQ that never fires, it's best
>> > to remove that code altogether and let future patches
>> > implement it if anybody needs those.
>> > 
>> > Signed-off-by: Felipe Balbi <balbi@...com>
>> 
>> Instead of introducing dummy ISR in previous patch and then removing in
>> this patch, both can be squashed into a single patch.
> 
> sure they can. I decided to split to ease review and to make sure only
> one thing happens in a single patch.

Indeed, I agree that adding something as a placeholder that just gets
immediately removed should be avoided unless it is extremely difficult
to do so.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html