netdev - RE: [PATCH v2 net] be2net: Allow GRE to work concurrently while a VxLAN tunnel is configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31318D46B5DF3F4AB71CC057601E9FEB3A7F61F2@CMEXMB1.ad.emulex.com>
Date:	Thu, 15 Jan 2015 05:45:19 +0000
From:	Sriharsha Basavapatna <Sriharsha.Basavapatna@...lex.Com>
To:	Tom Herbert <therbert@...gle.com>
CC:	Linux Netdev List <netdev@...r.kernel.org>
Subject: RE: [PATCH v2 net] be2net: Allow GRE to work concurrently while a
 VxLAN tunnel is configured



-----Original Message-----
From: Tom Herbert [mailto:therbert@...gle.com] 
Sent: Thursday, January 15, 2015 11:04 AM
To: Sriharsha Basavapatna
Cc: Linux Netdev List
Subject: Re: [PATCH v2 net] be2net: Allow GRE to work concurrently while a VxLAN tunnel is configured

> I don't understand why this is needed. The only GSO type with with encapsulation allowed by device features SKB_GSO_UDP_TUNNEL. This should not be GRE for instance. Do you see cases where protocol is not UDP at this point?
> [Harsha] It's needed for GRE checksum case; without this,  GRE pkts 
> are sent down without checksum by the stack, but HW can only offload checksum for VxLAN pkts.
>
Okay, I see that this is a problem with checksum not GSO. Please ask your hardware guys to provide NETIF_F_HW_CSUM to avoid any more of this unpleasantness in the future :-)
[Harsha] Ok, will do :-)

>> +           skb->inner_protocol_type != ENCAP_TYPE_ETHER ||
>> +           skb->inner_protocol != htons(ETH_P_TEB) ||
>> +           skb_inner_mac_header(skb) - skb_transport_header(skb) !=
>> +           sizeof(struct udphdr) + sizeof(struct vxlanhdr))
>> +               return features & ~(NETIF_F_ALL_CSUM | 
>> + NETIF_F_GSO_MASK);
>> +
>> +       return features;
>>  }
>>  #endif
>>
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in 
>> the body of a message to majordomo@...r.kernel.org More majordomo 
>> info at  http://vger.kernel.org/majordomo-info.html