netdev - Re: [PATCH for 3.19 2/3] rtlwifi: Fix handling of new style descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y4p4w8wb.fsf@kamboji.qca.qualcomm.com>
Date:	Thu, 15 Jan 2015 14:00:52 +0200
From:	Kalle Valo <kvalo@...eaurora.org>
To:	谭杭波 <troy_tan@...lsil.com.cn>
Cc:	"larry.finger" <Larry.Finger@...inger.net>,
	"linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>,
	"netdev\@vger.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH for 3.19 2/3] rtlwifi: Fix handling of new style descriptors

Hi Troy,

please avoid top-posting.

谭杭波 <troy_tan@...lsil.com.cn> writes:

> You can find get_available_desc here:
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/
> pci.c
> index e25faac..a62170e 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -578,6 +578,13 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int
> prio)
>                 else
>                         entry = (u8 *)(&ring->desc[ring->idx]);
>
> +               if (rtlpriv->cfg->ops->get_available_desc &&
> +                   rtlpriv->cfg->ops->get_available_desc(hw, prio) <= 1) {
> +                       RT_TRACE(rtlpriv, (COMP_INTR | COMP_SEND), DBG_DMESG,
> +                                "no available desc!\n");
> +                       return;
> +               }

I don't see rtlpriv->cfg->ops->get_available_desc set here, only being
called?

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html