lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Jan 2015 10:53:10 -0700 From: Shuah Khan <shuahkh@....samsung.com> To: Michael Ellerman <mpe@...erman.id.au>, linux-kernel@...r.kernel.org CC: mmarek@...e.cz, gregkh@...uxfoundation.org, akpm@...ux-foundation.org, rostedt@...dmis.org, mingo@...hat.com, davem@...emloft.net, keescook@...omium.org, tranmanphong@...il.com, cov@...eaurora.org, dh.herrmann@...il.com, hughd@...gle.com, bobby.prani@...il.com, serge.hallyn@...ntu.com, ebiederm@...ssion.com, tim.bird@...ymobile.com, josh@...htriplett.org, koct9i@...il.com, linux-kbuild@...r.kernel.org, linux-api@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 1/6] selftests: Introduce minimal shared logic for running tests On 01/09/2015 02:06 AM, Michael Ellerman wrote: > This adds a Make include file which most selftests can then include to > get the run_tests logic. > > On its own this has the advantage of some reduction in repetition, and > also means the pass/fail message is defined in fewer places. > > However the key advantage is it will allow us to implement install very > simply in a subsequent patch. > > The default implementation just executes each program in $(TEST_PROGS). > > We use a variable to hold the default implementation of $(RUN_TESTS) > because that gives us a clean way to override it if necessary, ie. using > override. The mount, memory-hotplug and mqueue tests use that to provide > a different implementation. > > Tests are not run via /bin/bash, so if they are scripts they must be > executable, we add u+x to several. > > Signed-off-by: Michael Ellerman <mpe@...erman.id.au> I like the shared logic approach in general provided it leaves the flexibility to not use the shared logic if a test have the need to do so. This series requires some patch planning. shared logic patch followed by individual test patches as opposed a single patch. I would like to see the shared logic work done on top of my patch v4 series. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@....samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists