lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Jan 2015 22:36:42 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Ben Hutchings <ben.hutchings@...ethink.co.uk>, ct178-internal@...ts.codethink.co.uk, "David S. Miller" <davem@...emloft.net> CC: netdev@...r.kernel.org, linux-kernel@...ts.codethink.co.uk, Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>, Mitsuhiro Kimura <mitsuhiro.kimura.kc@...esas.com>, Hisashi Nakamura <hisashi.nakamura.ak@...esas.com>, Yoshihiro Kaneko <ykaneko0929@...il.com> Subject: Re: [PATCH net 1/2] sh_eth: Fix promiscuous mode on chips without TSU On 01/16/2015 10:27 PM, Sergei Shtylyov wrote: >> Currently net_device_ops::set_rx_mode is only implemented for >> chips with a TSU (multiple address table). However we do need >> to turn the PRM (promiscuous) flag on and off for other chips. [...] >> Signed-off-by: Ben Hutchings <ben.hutchings@...ethink.co.uk> [...] >> diff --git a/drivers/net/ethernet/renesas/sh_eth.c >> b/drivers/net/ethernet/renesas/sh_eth.c >> index 167737f..0c4d5b5 100644 >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> +++ b/drivers/net/ethernet/renesas/sh_eth.c [...] >> @@ -2440,7 +2440,7 @@ static void sh_eth_tsu_purge_mcast(struct net_device >> *ndev) >> void *reg_offset = sh_eth_tsu_get_offset(mdp, TSU_ADRH0); >> int i; >> >> - if (unlikely(!mdp->cd->tsu)) >> + if (!mdp->cd->tsu) > But we don't call this function on non-TSU SoCs, do we? Sorry, we do. > [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists