[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAE4R7bA3QG4LDvVQywDsRuJzJYv4mBq3=OXi2L=qGDfa4a8ykw@mail.gmail.com>
Date: Fri, 16 Jan 2015 15:41:41 -0800
From: Scott Feldman <sfeldma@...il.com>
To: David Ahern <dsahern@...il.com>
Cc: Netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH] net: rocker: Add basic netdev counters - v2
On Fri, Jan 16, 2015 at 1:22 PM, David Ahern <dsahern@...il.com> wrote:
> Add packet and byte counters for RX and TX paths.
>
> $ ifconfig eth1
> eth1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500
> inet6 fe80::5054:ff:fe12:3501 prefixlen 64 scopeid 0x20<link>
> ether 52:54:00:12:35:01 txqueuelen 1000 (Ethernet)
> RX packets 63 bytes 15813 (15.4 KiB)
> RX errors 1 dropped 0 overruns 0 frame 0
> TX packets 79 bytes 17991 (17.5 KiB)
> TX errors 7 dropped 0 overruns 0 carrier 0 collisions 0
>
> Rx / Tx errors tested by injecting faults in qemu's hardware model for Rocker.
>
> v2:
> - moved counter locations to avoid potential use after free per Florian's comment
>
> Signed-off-by: David Ahern <dsahern@...il.com>
> Cc: Scott Feldman <sfeldma@...il.com>
> Cc: Jiri Pirko <jiri@...nulli.us>
Signed-off-by: Scott Feldman <sfeldma@...il.com>
Thanks David. I think this is good enough for first pass. Longer
term, I'd like to see this replaced by stats read from device for each
port.
-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists