netdev - Re: Compile-time warnings on mlx4/net-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1421412854.11734.118.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 16 Jan 2015 04:54:14 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	Marcelo Ricardo Leitner <mleitner@...hat.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: Compile-time warnings on mlx4/net-next

On Fri, 2015-01-16 at 12:45 +0100, Daniel Borkmann wrote:
> On 01/15/2015 02:38 PM, Marcelo Ricardo Leitner wrote:
> > On 15-01-2015 11:20, Or Gerlitz wrote:
> ...
> >>> Do you see them too?
> >>
> >> using $ make W=1 -j 20 SUBDIRS=./drivers/net/ethernet/mellanox/mlx4 with gcc
> >> 4.8.2 I don't see that, but I'll look there,
> >> thanks for the report.
> 
> I believe they are there for quite some time already. I'm using gcc 4.8.3
> and just default build. I'm surprised Fengguang didn't complain yet (or
> he did, but it got ignored somehow ;)). The following should be sufficient
> to just shut gcc up:
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
> index 982861d..b01154d 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/fw.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
> @@ -2122,6 +2122,7 @@ int mlx4_config_dev_retrieval(struct mlx4_dev *dev,
>   	if (!(dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_CONFIG_DEV))
>   		return -ENOTSUPP;
> 
> +	memset(&config_dev, 0, sizeof(config_dev));
>   	err = mlx4_CONFIG_DEV_get(dev, &config_dev);
>   	if (err)
>   		return err;

Yeah, I reported the same issue some time back.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html