netdev - Re: [PATCH] net: rocker: Add basic netdev counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bDrsA9xD=Bin8TTWzvH2XouaJ_crGvaHs2RuFEEgjAGJA@mail.gmail.com>
Date:	Fri, 16 Jan 2015 16:08:03 -0800
From:	Scott Feldman <sfeldma@...il.com>
To:	David Ahern <dsahern@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH] net: rocker: Add basic netdev counters - v2

On Fri, Jan 16, 2015 at 3:48 PM, David Ahern <dsahern@...il.com> wrote:
> On 1/16/15 4:41 PM, Scott Feldman wrote:
>>
>>
>> Thanks David.  I think this is good enough for first pass.  Longer
>> term, I'd like to see this replaced by stats read from device for each
>> port.
>
>
> Aren't there 2 sets of stats at play here?
> 1. packets punted to the control plane / CPU,
> 2. packets forwarded through the ports.

You're right.

> If you have the netdev counters resemble packets handled through the port it
> could be confusing to someone looking at packets handled by the OS.

Agreed, keep traditional netdev stats for pkts to/from OS.  Maybe
we're done then?

> What about having detailed counters local to the driver (i.e., ethtool -S)
> show the low level stats like packets handled through the port?

That sounds perfect, to use ethtool -S for extended device stats.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html