netdev - Re: [patch net-next 2/2] net: replace br_fdb_external_learn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150117083112.GB1891@nanopsycho.orion>
Date:	Sat, 17 Jan 2015 09:31:12 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Scott Feldman <sfeldma@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Scott Feldman <sfeldma@...il.co>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	linus.luessing@....de, Thomas Graf <tgraf@...g.ch>
Subject: Re: [patch net-next 2/2] net: replace br_fdb_external_learn_* calls
 with switchdev notifier events

Fri, Jan 16, 2015 at 08:32:34PM CET, sfeldma@...il.com wrote:
>On Thu, Jan 15, 2015 at 2:49 PM, Jiri Pirko <jiri@...nulli.us> wrote:
>> This patch benefits from newly introduced switchdev notifier and uses it
>> to propagate fdb learn events from rocker driver to bridge. That avoids
>> direct function calls and possible use by other listeners (ovs).
>>
>> Suggested-by: Thomas Graf <tgraf@...g.ch>
>> Signed-off-by: Jiri Pirko <jiri@...nulli.us>
>
>Signed-off-by: Scott Feldman <sfeldma@...il.com>
>
>>  drivers/net/ethernet/rocker/rocker.c | 10 +++++--
>>  include/linux/if_bridge.h            | 18 -------------
>>  include/net/switchdev.h              | 11 ++++++++
>>  net/bridge/br.c                      | 52 +++++++++++++++++++++++++++++++++++-
>>  net/bridge/br_fdb.c                  | 38 +++-----------------------
>>  net/bridge/br_private.h              |  4 +++
>>  6 files changed, 78 insertions(+), 55 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
>> index cad8cf9..964d719 100644
>> --- a/drivers/net/ethernet/rocker/rocker.c
>> +++ b/drivers/net/ethernet/rocker/rocker.c
>> @@ -3026,11 +3026,17 @@ static void rocker_port_fdb_learn_work(struct work_struct *work)
>>                 container_of(work, struct rocker_fdb_learn_work, work);
>>         bool removing = (lw->flags & ROCKER_OP_FLAG_REMOVE);
>>         bool learned = (lw->flags & ROCKER_OP_FLAG_LEARNED);
>> +       struct netdev_switch_notifier_fdb_info info;
>> +
>> +       info.addr = lw->addr;
>> +       info.vid = lw->vid;
>
>If you respin patch, use initializer to zero out other members, just
>to future proof it.

There are no other members :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html