netdev - Re: Regression from "ipv4: Cache ip_error() routes even when not forwarding."

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+HUmGjWOhgEvvtmC=F9TiDbOBXKwcVC+oOtg_vQ2i3G7M5Jng@mail.gmail.com>
Date:	Sat, 17 Jan 2015 08:30:20 -0800
From:	Francesco Ruggeri <fruggeri@...sta.com>
To:	Julian Anastasov <ja@....bg>
Cc:	Francesco Ruggeri <fruggeri@...stanetworks.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: Regression from "ipv4: Cache ip_error() routes even when not forwarding."

On Sat, Jan 17, 2015 at 12:25 AM, Julian Anastasov <ja@....bg> wrote:
>
>         Hello,
>
> On Fri, 16 Jan 2015, Francesco Ruggeri wrote:
>
>> Commit 251da413("ipv4: Cache ip_error() routes even when not forwarding."),
>> later slightly modified by cd0f0b95("ipv4: distinguish EHOSTUNREACH from
>> the ENETUNREACH"), introduced a regression where an ip_error route is cached
>> when an ARP request is received on a non-forwarding non matching interface,
>> and it affects later legitimate packets for the same destination even if
>> coming over different interfaces.
>> Attached are two scripts that show the problem. The first one does basic
>> forwarding, and the second one does proxy arp.
>> In both cases a dummy interface is created for the sole purpose of receiving
>> an ARP request that results in the ip_error route to be cached. The offending
>> ARP request is generated by using a 'ping -c 1' (commented out in the scripts).
>> Verified in 3.16 build.
>
>         3.16? Just in case, can you check if this
> fix from 3.18 helps:

Thanks, I will.

Francesco

>
> commit fa19c2b050ab5254326f5fc07096dd3c6a8d5d58
> Author: Nicolas Cavallari <nicolas.cavallari@...en-communications.fr>
> Date:   Thu Oct 30 10:09:53 2014 +0100
>
>     ipv4: Do not cache routing failures due to disabled forwarding.
>
> Regards
>
> --
> Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html