lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20150118.015604.372132289619316404.davem@davemloft.net>
Date:	Sun, 18 Jan 2015 01:56:04 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	dsahern@...il.com, netdev@...r.kernel.org, jiri@...nulli.us
Subject: Re: [PATCH] net: rocker: Add basic netdev counters - v2

From: Scott Feldman <sfeldma@...il.com>
Date: Fri, 16 Jan 2015 15:41:41 -0800

> On Fri, Jan 16, 2015 at 1:22 PM, David Ahern <dsahern@...il.com> wrote:
>> Add packet and byte counters for RX and TX paths.
>>
>> $ ifconfig eth1
>> eth1: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
>>         inet6 fe80::5054:ff:fe12:3501  prefixlen 64  scopeid 0x20<link>
>>         ether 52:54:00:12:35:01  txqueuelen 1000  (Ethernet)
>>         RX packets 63  bytes 15813 (15.4 KiB)
>>         RX errors 1  dropped 0  overruns 0  frame 0
>>         TX packets 79  bytes 17991 (17.5 KiB)
>>         TX errors 7  dropped 0 overruns 0  carrier 0  collisions 0
>>
>> Rx / Tx errors tested by injecting faults in qemu's hardware model for Rocker.
>>
>> v2:
>> - moved counter locations to avoid potential use after free per Florian's comment
>>
>> Signed-off-by: David Ahern <dsahern@...il.com>
>> Cc: Scott Feldman <sfeldma@...il.com>
>> Cc: Jiri Pirko <jiri@...nulli.us>
> 
> Signed-off-by: Scott Feldman <sfeldma@...il.com>
> 
> Thanks David.  I think this is good enough for first pass.  Longer
> term, I'd like to see this replaced by stats read from device for each
> port.

Ok, applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ