netdev - Re: Bridge code in net-next does not compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DF3B96A8-5E4E-4EF4-8C42-8981B76F967B@holtmann.org>
Date:	Sun, 18 Jan 2015 02:45:26 -0800
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	Network Development <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: Bridge code in net-next does not compile

Hi Jiri,

>> when compiling net-next, the bridge code fails to compile:
>> 
>> CC      net/bridge/br.o
>> In file included from net/bridge/br.c:22:0:
>> include/net/switchdev.h:73:1: error: expected identifier or ‘(’ before ‘{’ token
>> {
>> ^
>> include/net/switchdev.h:71:90: warning: ‘call_netdev_switch_notifiers’ declared ‘static’ but never defined [-Wunused-function]
>> static inline int call_netdev_switch_notifiers(unsigned long val, struct net_device *dev,
> 
> Hi, I already sent fix:
> 
> http://patchwork.ozlabs.org/patch/430160/

good. I was just building the same fix for it. Except with an actual commit message showing the error.

Next time please compile test your patches with CONFIG_NET_SWITCHDEV=n. You were adding code that depends on a kernel config option. So that should have been something obvious to actually compile test.

Dave, if you prefer a commit message with the error, then I can send my patch.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html