netdev - Re: [net-next PATCH v2 1/1] net: sched: Introduce connmark action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7Muz_d47NX01tKO7v7V7m=5mKf+BPP1jo9dEH==8R6bgw@mail.gmail.com>
Date:	Sun, 18 Jan 2015 13:00:11 -0800
From:	Cong Wang <cwang@...pensource.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, nbd@...nwrt.org,
	pablo@...filter.org, Florian Westphal <fw@...len.de>,
	Jiří Pírko <jiri@...nulli.us>
Subject: Re: [net-next PATCH v2 1/1] net: sched: Introduce connmark action

On Sun, Jan 18, 2015 at 12:00 PM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
> +
> +MODULE_AUTHOR("Felix Fietkau <nbd@...nwrt.org>");
> +MODULE_DESCRIPTION("Connection tracking mark restoring");
> +MODULE_LICENSE("GPL");


Please move these to the bottom.

> +
> +static int __init connmark_init_module(void)
> +{
> +       int ret;
> +
> +       ret = tcf_hashinfo_init(&connmark_hash_info, CONNMARK_TAB_MASK);
> +       if (ret)
> +               return ret;
> +

Is this against latest net-next? We don't need to init the hashinfo anymore,
tcf_register_action() already does that.

> +       return tcf_register_action(&act_connmark_ops, CONNMARK_TAB_MASK);
> +}
> +
> +static void __exit connmark_cleanup_module(void)
> +{
> +       tcf_unregister_action(&act_connmark_ops);
> +}
> +

Even if we really needed, you forgot to call tcf_hashinfo_destroy()?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html