netdev - Re: [PATCH net-next] mii: Handle link state changes for forced modes in mii_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150119.154009.1883297001784841706.davem@davemloft.net>
Date:	Mon, 19 Jan 2015 15:40:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ben.hutchings@...ethink.co.uk
Cc:	ct178-internal@...ts.codethink.co.uk, netdev@...r.kernel.org,
	linux-kernel@...ts.codethink.co.uk
Subject: Re: [PATCH net-next] mii: Handle link state changes for forced
 modes in mii_check_media()

From: Ben Hutchings <ben.hutchings@...ethink.co.uk>
Date: Fri, 16 Jan 2015 17:55:35 +0000

> mii_check_media() does not update the link (carrier) state or log link
> changes when the link mode is forced.  Drivers using the mii library
> must do this themselves, but most of them do not.
> 
> Instead of changing them all, provide a sensible default behaviour
> similar to mii_check_link() when the mode is forced.
> 
> via-rhine depends on it being a no-op in this case, so make its call
> to mii_check_media() conditional.
> 
> Signed-off-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>

Seems reasonable, applied, thanks Ben.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html