netdev - Re: [net-next PATCH v3 1/1] net: sched: Introduce connmark action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150119.160223.1328042503373891210.davem@davemloft.net>
Date:	Mon, 19 Jan 2015 16:02:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jhs@...atatu.com
Cc:	netdev@...r.kernel.org, nbd@...nwrt.org, pablo@...filter.org,
	fw@...len.de, jiri@...nulli.us, cwang@...pensource.com
Subject: Re: [net-next PATCH v3 1/1] net: sched: Introduce connmark action

From: Jamal Hadi Salim <jhs@...atatu.com>
Date: Sun, 18 Jan 2015 16:35:14 -0500

> From: Felix Fietkau <nbd@...nwrt.org>
> 
> This tc action allows you to retrieve the connection tracking mark
> This action has been used heavily by openwrt for a few years now.
> 
> There are known limitations currently:
> 
> doesn't work for initial packets, since we only query the ct table.
>   Fine given use case is for returning packets
> 
> no implicit defrag.
>   frags should be rare so fix later..
> 
> won't work for more complex tasks, e.g. lookup of other extensions
>   since we have no means to store results
> 
> we still have a 2nd lookup later on via normal conntrack path.
> This shouldn't break anything though since skb->nfct isn't altered.
> 
> V2:
> remove unnecessary braces (Jiri)
> change the action identifier to 14 (Jiri)
> Fix some stylistic issues caught by checkpatch
> V3:
> Move module params to bottom (Cong)
> Get rid of tcf_hashinfo_init and friends and conform to newer API (Cong)

Applied, thanks Jamal.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html