netdev - Re: Problem with patch "make nlmsg_end() and genlmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bCThwbQ80kYbY9rNhLOyjzs6eONKiOoQR=K8CrLARDF1A@mail.gmail.com>
Date:	Mon, 19 Jan 2015 01:31:24 -0800
From:	Scott Feldman <sfeldma@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Marcel Holtmann <marcel@...tmann.org>,
	Netdev <netdev@...r.kernel.org>,
	Johannes Berg <johannes@...solutions.net>,
	Tom Gundersen <teg@...m.no>
Subject: Re: Problem with patch "make nlmsg_end() and genlmsg_end() void"

On Sun, Jan 18, 2015 at 8:37 PM, David Miller <davem@...emloft.net> wrote:
>
> ====================
> [PATCH] netlink: Fix bugs in nlmsg_end() conversions.
>
> Commit 053c095a82cf ("netlink: make nlmsg_end() and genlmsg_end()
> void") didn't catch all of the cases where callers were breaking out
> on the return value being equal to zero, which they no longer should
> when zero means success.
>
> Fix all such cases.
>
> Reported-by: Marcel Holtmann <marcel@...tmann.org>
> Reported-by: Scott Feldman <sfeldma@...il.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>

Fixes my tests, so I'm happy.  Thank you.

Acked-by: Scott Feldman <sfeldma@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html