netdev - Re: [net-next PATCH v3 01/12] net: flow_table: create interface for hw match/action tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150122043756.GA32765@vergenet.net>
Date:	Thu, 22 Jan 2015 13:37:58 +0900
From:	Simon Horman <simon.horman@...ronome.com>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	tgraf@...g.ch, sfeldma@...il.com, netdev@...r.kernel.org,
	jhs@...atatu.com, davem@...emloft.net, gerlitz.or@...il.com,
	andy@...yhouse.net, ast@...mgrid.com
Subject: Re: [net-next PATCH v3 01/12] net: flow_table: create interface for
 hw match/action tables

On Tue, Jan 20, 2015 at 12:26:37PM -0800, John Fastabend wrote:

[snip]

> diff --git a/include/linux/if_flow.h b/include/linux/if_flow.h
> new file mode 100644
> index 0000000..7ce1e1d
> --- /dev/null
> +++ b/include/linux/if_flow.h
> @@ -0,0 +1,188 @@

[snip]

> +#define NFL_JUMP_TABLE_DONE 0
> +enum {
> +	NFL_JUMP_ENTRY_UNSPEC,
> +	NFL_JUMP_ENTRY,
> +	__NFL_JUMP_ENTRY_MAX,
> +};

For consistency it seems that the following could go here:

#define NFL_JUMP_ENTRY_MAX (__NFL_JUMP_ENTRY_MAX - 1)

> +enum {
> +	NFL_HEADER_NODE_HDRS_UNSPEC,
> +	NFL_HEADER_NODE_HDRS_VALUE,
> +	__NFL_HEADER_NODE_HDRS_MAX,
> +};
> +
> +#define NFL_HEADER_NODE_HDRS_MAX (__NFL_HEADER_NODE_HDRS_MAX - 1)
> +
> +enum {
> +	NFL_HEADER_NODE_UNSPEC,
> +	NFL_HEADER_NODE_NAME,
> +	NFL_HEADER_NODE_UID,
> +	NFL_HEADER_NODE_HDRS,
> +	NFL_HEADER_NODE_JUMP,
> +	__NFL_HEADER_NODE_MAX,
> +};
> +
> +#define NFL_HEADER_NODE_MAX (__NFL_HEADER_NODE_MAX - 1)
> +
> +enum {
> +	NFL_HEADER_GRAPH_UNSPEC,
> +	NFL_HEADER_GRAPH_NODE,
> +	__NFL_HEADER_GRAPH_MAX,
> +};
> +
> +#define NFL_HEADER_GRAPH_MAX (__NFL_HEADER_GRAPH_MAX - 1)

[snip]
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html