lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Jan 2015 07:15:58 +0100 From: Mike Galbraith <umgwanakikbuti@...il.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: netdev <netdev@...r.kernel.org> Subject: Re: netxen: box stuck in netxen_napi_disable() On Wed, 2015-01-21 at 21:57 -0800, Eric Dumazet wrote: > This driver doesn't follow the NAPI model correctly. > > Please try following fix : Thanks Eric, I'll plug it in in a bit and poke at it. No news is good news, as good as news gets for unknown repeatability bugs that is ;-) > diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c > index 613037584d08..c531c8ae1be4 100644 > --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c > +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c > @@ -2388,7 +2388,10 @@ static int netxen_nic_poll(struct napi_struct *napi, int budget) > > work_done = netxen_process_rcv_ring(sds_ring, budget); > > - if ((work_done < budget) && tx_complete) { > + if (!tx_complete) > + work_done = budget; > + > + if (work_done < budget) { > napi_complete(&sds_ring->napi); > if (test_bit(__NX_DEV_UP, &adapter->state)) > netxen_nic_enable_int(sds_ring); > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists