netdev - Re: [PATCH 2/3] stmmac: hardware TX COE doesn't work when force_thresh_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54C0B25D.2050508@st.com>
Date:	Thu, 22 Jan 2015 09:18:37 +0100
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Sonic Zhang <sonic.adi@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>,
	<adi-buildroot-devel@...ts.sourceforge.net>,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH 2/3] stmmac: hardware TX COE doesn't work when force_thresh_dma_mode
 is set

On 1/22/2015 7:55 AM, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@...log.com>
>
> Clear the TX COE bit when force_thresh_dma_mode is set even hardware
> dma capability says support.
>
> Tested on BF609.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>   drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 5edfc8a..7a7385a 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2746,7 +2746,11 @@ static int stmmac_hw_init(struct stmmac_priv *priv)
>   		priv->plat->enh_desc = priv->dma_cap.enh_desc;
>   		priv->plat->pmt = priv->dma_cap.pmt_remote_wake_up;
>
> -		priv->plat->tx_coe = priv->dma_cap.tx_coe;
> +		/* TXCOE doesn't work in thresh DMA mode */
> +		if (priv->plat->force_thresh_dma_mode)
> +			priv->plat->tx_coe = 0;
> +		else
> +			priv->plat->tx_coe = priv->dma_cap.tx_coe;
>
>   		if (priv->dma_cap.rx_coe_type2)
>   			priv->plat->rx_coe = STMMAC_RX_COE_TYPE2;
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html