netdev - Re: [PATCH net] ipvlan: fix incorrect usage of IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 25 Jan 2015 00:24:45 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	maheshb@...gle.com
Cc:	netdev@...r.kernel.org, edumazet@...gle.com,
	dan.carpenter@...cle.com
Subject: Re: [PATCH net] ipvlan: fix incorrect usage of IS_ERR() macro in
 IPv6 code path.

From: Mahesh Bandewar <maheshb@...gle.com>
Date: Sat, 24 Jan 2015 21:53:43 -0800

> The ip6_route_output() always returns a valid dst pointer unlike in IPv4
> case. So the validation has to be different from the IPv4 path. Correcting
> that error in this patch.
> 
> This was picked up by a static checker with a following warning -
> 
>    drivers/net/ipvlan/ipvlan_core.c:380 ipvlan_process_v6_outbound()
>         warn: 'dst' isn't an ERR_PTR
> 
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html