lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Jan 2015 13:46:33 +0100 From: Hannes Frederic Sowa <hannes@...essinduktion.org> To: Erik Kline <ek@...gle.com>, netdev@...r.kernel.org Cc: davem@...emloft.net Subject: Re: [PATCH net] net: ipv6: allow explicitly choosing optimistic addresses Hi, On Wed, Jan 21, 2015, at 08:02, Erik Kline wrote: > if (ipv6_addr_equal(&ifp->addr, addr) && > - !(ifp->flags&IFA_F_TENTATIVE) && > + (!(ifp->flags&IFA_F_TENTATIVE) || > + ifp->flags&IFA_F_OPTIMISTIC) && > + !(ifp->flags&banned_flags) && > (dev == NULL || ifp->idev->dev == dev || Can the wrapper take the IFA_F_TENTATIVE and IFA_F_OPTIMISTIC into the banned_flags argument, so this condition becomes easier to read? The new caller could also specify them verbatim. I think it would improve readability. Thanks, Hannes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists