netdev - Re: [PATCH] net:wireless:Add proper locking for the function, b43_op_beacon_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <54C51F25.9050602@lwfinger.net>
Date:	Sun, 25 Jan 2015 10:51:49 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Nicholas Krause <xerofoify@...il.com>
CC:	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	b43-dev@...ts.infradead.org, kvalo@...eaurora.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net:wireless:Add proper locking for the function, b43_op_beacon_set_tim
 in main.c

On 01/25/2015 01:06 AM, Nicholas Krause wrote:
> Adds proper locking for the function, b43_op_beacon_set_tim in main.c that internally calls b43_update_templates.
> Due to the function that is being called internally,b43_update_templates needing the mutex lock of the structure
> pointer wl passed  it to run successfully and without issues we add the calls to mutex_lock before and mutex_unlock
> after it's call internally in b43_op_beacon_set_tim in order to allow the function,,b43_update_templates to run
> successfully and without issues related to concurrent access.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>   drivers/net/wireless/b43/main.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index 47731cb..b807958 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw,
>   {
>   	struct b43_wl *wl = hw_to_b43_wl(hw);
>
> -	/* FIXME: add locking */
> +	mutex_lock(&wl->mutex);
>   	b43_update_templates(wl);
> +	mutex_unlock(&wl->mutex);
>
>   	return 0;
>   }

Nicolas,

You must be an idiot for resubmitting this patch after Michael Busch clearly 
told you that this patch can *never* work as we are in atomic context here! If 
you are looking for patch credits, submitting one that messes with locking *that 
you have never tested* will certainly get you notoriety on the Internet, but I 
doubt that you want that bad a reputation!!

NACK.

Larry


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html