netdev - Re: [PATCH net-next 1/1] net: phy: unbind phy device from generic and specifical driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Jan 2015 09:14:25 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Fugang Duan <b38611@...escale.com>, davem@...emloft.net
CC:	netdev@...r.kernel.org, s.hauer@...gutronix.de,
	bhutchings@...arflare.com, stephen@...workplumber.org
Subject: Re: [PATCH net-next 1/1] net: phy: unbind phy device from generic
 and specifical driver

On 26/01/15 00:14, Fugang Duan wrote:
> The current .phy_detach() function only unbind generic phy driver, which causes
> specifical driver suspend/resume function still work like Atheros AT803X PHYs.
> 
> For example:
> ifconfig eth0 down
> echo mem > /sys/power/status
> 
> After eth0 interface down, driver call phy_detach to unbind phy driver, and then
> do suspend/resume operation, at803x_suspend()/at803x_resume() functions still get
> called that call mdio bus read/write function. When eth0 interface down, MAC driver
> may close all clocks and mdio bus cannot work. So the issue happens.

I was just hitting this problem on Friday evening and was about to
submit a similar change. Thanks!

> 
> The patch can unbind generic and specifical driver.
> 
> Signed-off-by: Fugang Duan <B38611@...escale.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
Tested-by: Florian Fainelli <f.fainelli@...il.com>


> ---
>  drivers/net/phy/phy_device.c |   15 ++-------------
>  1 files changed, 2 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 3fc91e8..8adbc5d 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -672,8 +672,6 @@ EXPORT_SYMBOL(phy_attach);
>   */
>  void phy_detach(struct phy_device *phydev)
>  {
> -	int i;
> -
>  	if (phydev->bus->dev.driver)
>  		module_put(phydev->bus->dev.driver->owner);
>  
> @@ -681,17 +679,8 @@ void phy_detach(struct phy_device *phydev)
>  	phydev->attached_dev = NULL;
>  	phy_suspend(phydev);
>  
> -	/* If the device had no specific driver before (i.e. - it
> -	 * was using the generic driver), we unbind the device
> -	 * from the generic driver so that there's a chance a
> -	 * real driver could be loaded
> -	 */
> -	for (i = 0; i < ARRAY_SIZE(genphy_driver); i++) {
> -		if (phydev->dev.driver == &genphy_driver[i].driver) {
> -			device_release_driver(&phydev->dev);
> -			break;
> -		}
> -	}
> +	if (phydev->dev.driver)
> +		device_release_driver(&phydev->dev);
>  }
>  EXPORT_SYMBOL(phy_detach);
>  
> 


-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html