netdev - Re: [PATCH net-next v2] rhashtable: rhashtable_remove() must unlink in both tbl and future

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150126.115704.1748957006917820310.davem@davemloft.net>
Date:	Mon, 26 Jan 2015 11:57:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	sergei.shtylyov@...entembedded.com, ying.xue@...driver.com,
	richard.alpe@...csson.com, netdev@...r.kernel.org,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next v2] rhashtable: rhashtable_remove() must
 unlink in both tbl and future_tbl

From: Thomas Graf <tgraf@...g.ch>
Date: Wed, 21 Jan 2015 11:54:01 +0000

> As removals can occur during resizes, entries may be referred to from
> both tbl and future_tbl when the removal is requested. Therefore
> rhashtable_remove() must unlink the entry in both tables if this is
> the case. The existing code did search both tables but stopped when it
> hit the first match.
> 
> Failing to unlink in both tables resulted in use after free.
> 
> Fixes: 97defe1ecf86 ("rhashtable: Per bucket locks & deferred expansion/shrinking")
> Reported-by: Ying Xue <ying.xue@...driver.com>
> Signed-off-by: Thomas Graf <tgraf@...g.ch>
> ---
> v2: 12 digit commit reference, commit msg clarification as pointed
>     out by Sergei.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html