netdev - Re: [PATCH net-next v3 2/2] iproute2: bridge vlan show new option to print ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE4R7bCR6YSK9J+OV+04w_UXWoSu56xSvHXkYkDzqP4Qudn76Q@mail.gmail.com>
Date:	Sun, 25 Jan 2015 20:35:52 -0800
From:	Scott Feldman <sfeldma@...il.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:	Netdev <netdev@...r.kernel.org>, shemminger@...tta.com,
	"vyasevic@...hat.com" <vyasevic@...hat.com>,
	Wilson Kok <wkok@...ulusnetworks.com>
Subject: Re: [PATCH net-next v3 2/2] iproute2: bridge vlan show new option to
 print ranges

> diff --git a/bridge/bridge.c b/bridge/bridge.c
> index 5fcc552..88469ca 100644
> --- a/bridge/bridge.c
> +++ b/bridge/bridge.c
> @@ -21,6 +21,7 @@ int resolve_hosts;
>  int oneline = 0;
>  int show_stats;
>  int show_details;
> +int compress_vlans;
>  int timestamp;
>  char * _SL_ = NULL;
>
> @@ -32,7 +33,8 @@ static void usage(void)
>  "Usage: bridge [ OPTIONS ] OBJECT { COMMAND | help }\n"
>  "where  OBJECT := { link | fdb | mdb | vlan | monitor }\n"
>  "       OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
> -"                    -o[neline] | -t[imestamp] | -n[etns] name }\n");
> +"                    -o[neline] | -t[imestamp] | -n[etns] name |\n"
> +"                    -c[ompressvlans] }\n");

This option is awkward at this level since it's specific to bridge vlan cmd.

Is it even necessary?  The real user of compressed vlans isn't the
"bridge show" cmd; just keep "bridge show" simple, listing each vlan
per line.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html