lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Jan 2015 23:33:16 -0800 (PST) From: David Miller <davem@...emloft.net> To: dan.carpenter@...cle.com Cc: stephen@...workplumber.org, bridge@...ts.linux-foundation.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] bridge: simplify br_getlink() a bit From: Dan Carpenter <dan.carpenter@...cle.com> Date: Wed, 21 Jan 2015 12:22:35 +0300 > Static checkers complain that we should maybe set "ret" before we do the > "goto out;". They interpret the NULL return from br_port_get_rtnl() as > a failure and forgetting to set the error code is a common bug in this > situation. > > The code is confusing but it's actually correct. We are returning zero > deliberately. Let's re-write it a bit to be more clear. > > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists