netdev - Re: [PATCH 1/1 net-next] dev: add per net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150127.000201.1561369463873997294.davem@davemloft.net>
Date:	Tue, 27 Jan 2015 00:02:01 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	noureddine@...sta.com
Cc:	edumazet@...gle.com, therbert@...gle.com, jiri@...nulli.us,
	vyasevic@...hat.com, netdev@...r.kernel.org, ebiederm@...ssion.com
Subject: Re: [PATCH 1/1 net-next] dev: add per net_device packet type chains

From: Salam Noureddine <noureddine@...sta.com>
Date: Fri, 23 Jan 2015 12:07:23 -0800

>  	/* deliver only exact match when indicated */
> -	null_or_dev = deliver_exact ? skb->dev : NULL;
> +	if (likely(!deliver_exact)) {
> +		deliver_ptype_list_skb(skb, &pt_prev, orig_dev, type,
> +				&ptype_base[ntohs(type) & PTYPE_HASH_MASK]);
> +	}

This is not indented properly.

A call that spans multiple lines should have the arguments on the
second and subsequent lines begin precisely at the first column
after the openning parenthesis on the first line.

Please fix this up and resubmit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html