netdev - Re: [PATCH] ping: Fix race in free in receive path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150127.000521.291244489423335210.davem@davemloft.net>
Date:	Tue, 27 Jan 2015 00:05:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	subashab@...eaurora.org
Cc:	netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH] ping: Fix race in free in receive path

From: subashab@...eaurora.org
Date: Fri, 23 Jan 2015 22:26:02 -0000

> An exception is seen in ICMP ping receive path where the skb
> destructor sock_rfree() tries to access a freed socket. This happens
> because ping_rcv() releases socket reference with sock_put() and this
> internally frees up the socket. Later icmp_rcv() will try to free the
> skb and as part of this, skb destructor is called and which leads
> to a kernel panic as the socket is freed already in ping_rcv().
> 
> -->|exception
> -007|sk_mem_uncharge
> -007|sock_rfree
> -008|skb_release_head_state
> -009|skb_release_all
> -009|__kfree_skb
> -010|kfree_skb
> -011|icmp_rcv
> -012|ip_local_deliver_finish
> 
> Fix this incorrect free by cloning this skb and processing this cloned
> skb instead.
> 
> This patch was suggested by Eric Dumazet
> 
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html