netdev - Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150127.002733.2208362585040497182.davem@davemloft.net>
Date:	Tue, 27 Jan 2015 00:27:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	vyasevich@...il.com, netdev@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, mst@...hat.com,
	edumazet@...gle.com, vyasevic@...hat.com
Subject: Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO
 segmentation if not set.

From: Ben Hutchings <ben@...adent.org.uk>
Date: Tue, 27 Jan 2015 02:47:54 +0000

> On Mon, 2015-01-26 at 09:37 -0500, Vladislav Yasevich wrote:
>> If the IPv6 fragment id has not been set and we perform
>> fragmentation due to UFO, select a new fragment id.
>> When we store the fragment id into skb_shinfo, set the bit
>> in the skb so we can re-use the selected id.
>> This preserves the behavior of UFO packets generated on the
>> host and solves the issue of id generation for packet sockets
>> and tap/macvtap devices.
>> 
>> This patch moves ipv6_select_ident() back in to the header file.  
>> It also provides the helper function that sets skb_shinfo() frag
>> id and sets the bit.
>> 
>> It also makes sure that we select the fragment id when doing
>> just gso validation, since it's possible for the packet to
>> come from an untrusted source (VM) and be forwarded through
>> a UFO enabled device which will expect the fragment id.
>> 
>> CC: Eric Dumazet <edumazet@...gle.com>
>> Signed-off-by: Vladislav Yasevich <vyasevic@...hat.com>

Applied, thanks Ben.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html