netdev - Re: [PATCH net-next] net: phy: Invalidate LP advertising flags when restarting or disabling AN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54C6E4A9.6070603@gmail.com>
Date:	Mon, 26 Jan 2015 17:06:49 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Ben Hutchings <ben.hutchings@...ethink.co.uk>
CC:	netdev@...r.kernel.org, linux-kernel@...ts.codethink.co.uk
Subject: Re: [PATCH net-next] net: phy: Invalidate LP advertising flags when
 restarting or disabling AN

On 26/01/15 16:58, Ben Hutchings wrote:
> It is possible to see the old value of the LP advertising flags
> through ethtool after reconfiguring the PHY and before autonegotiation
> completes.  If autonegotiation is turned off then the last value seen
> will persist indefinitely.

Good catch!

> 
> Signed-off-by: Ben Hutchings <ben.hutchings@...ethink.co.uk>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

> ---
>  drivers/net/phy/phy.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 767cd11..cdcac6a 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -439,6 +439,9 @@ int phy_start_aneg(struct phy_device *phydev)
>  	if (AUTONEG_DISABLE == phydev->autoneg)
>  		phy_sanitize_settings(phydev);
>  
> +	/* Invalidate LP advertising flags */
> +	phydev->lp_advertising = 0;
> +
>  	err = phydev->drv->config_aneg(phydev);
>  	if (err < 0)
>  		goto out_unlock;
> 


-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html