netdev - Re: [RFC PATCH] net: ipv6: Make address flushing on ifdown optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1422433559.4678.15.camel@stressinduktion.org>
Date:	Wed, 28 Jan 2015 09:25:59 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	David Ahern <dsahern@...il.com>
Cc:	Andy Gospodarek <gospo@...ulusnetworks.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org
Subject: Re: [RFC PATCH] net: ipv6: Make address flushing on ifdown optional

On Di, 2015-01-27 at 20:21 -0700, David Ahern wrote:
> On 01/27/2015 08:28 AM, Hannes Frederic Sowa wrote:
> >>   From the discussion a second patch is needed to make sure DAD is done
> >> on a link up if there is an address configured.
> >
> > Thank you!
> >
> > Let's see if the DAD patch isn't complex, maybe it is a candidate for
> > stable?
> 
> Actually, DAD is done on a link up; you can see the notifications go out 
> when the link is brought up:

Oh, cool, sorry I did not check and misunderstood you in the other mail.

> 18:46:28.519907 IP6 :: > ff02::1:ff00:10: ICMP6, neighbor solicitation, 
> who has 2001:1::10, length 24
> 18:46:28.607650 IP6 :: > ff02::1:ff03:402: ICMP6, neighbor solicitation, 
> who has fe80::1:2ff:fe03:402, length 24
> 
> So current top of tree works fine wrt DAD on addresses added when a link 
> is down and then the link is brought up.
> 
> But, my previous patch does not re-send notifications on the up in a 
> down-up cycle. I believe it is because the IFA_F_TENTATIVE flag is not 
> set for the global address configured. I will address that in the 
> revised patch.

Sounds good, I don't see any more problems with this patch then.

Thanks!


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html