netdev - Re: [PATCH net] ppp: deflate: never return len larger than output buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150129.145029.2079802415674560097.davem@davemloft.net>
Date:	Thu, 29 Jan 2015 14:50:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] ppp: deflate: never return len larger than output
 buffer

From: Florian Westphal <fw@...len.de>
Date: Wed, 28 Jan 2015 10:56:04 +0100

> When we've run out of space in the output buffer to store more data, we
> will call zlib_deflate with a NULL output buffer until we've consumed
> remaining input.
> 
> When this happens, olen contains the size the output buffer would have
> consumed iff we'd have had enough room.
> 
> This can later cause skb_over_panic when ppp_generic skb_put()s
> the returned length.
> 
> Reported-by: Iain Douglas <centos@....org.uk>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied and queued up for -stable, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html