netdev - Re: [PATCH] cxgb4: Remove preprocessor check for CONFIG_CXGB4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150129.151030.621632674659139306.davem@davemloft.net>
Date:	Thu, 29 Jan 2015 15:10:30 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hariprasad@...lsio.com
Cc:	netdev@...r.kernel.org, leedom@...lsio.com, anish@...lsio.com,
	nirranjan@...lsio.com, praveenm@...lsio.com
Subject: Re: [PATCH] cxgb4: Remove preprocessor check for CONFIG_CXGB4_DCB

From: Hariprasad Shenai <hariprasad@...lsio.com>
Date: Wed, 28 Jan 2015 21:49:51 +0530

> In commit dc9daab226aa ("cxgb4: Added support in debugfs to dump
> sge_qinfo") a preprocessor check for CONFIG_CXGB4_DCB got added, which should
> have been CONFIG_CHELSIO_T4_DCB.
> 
> Reported-by: Paul Bolle <pebolle@...cal.nl>
> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>

That's not all this patch is doing:

> +static inline struct port_info *ethqset2pinfo(struct adapter *adap, int qset)

You need to explain why this function needs to be added in the
commit message.

I can see myself that the build fails without it because you
forgot to add it in the original commit, or someone removed
it meanwhile, but you have to say so in the commit message
so everyone can understand.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html